Repository navigation
Conversation
COMBINED_LOCALE_DIR and freetextresponse's dummy_locales are no longer read now that only extract_translations remains. Also drop a stray leading space before the tab on the mv line. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The README and i18n how-to still described the combined text.po catalog and the removed compile, dummy and Transifex targets. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 48 48
Lines 1461 1461
Branches 117 117
=======================================
Hits 1208 1208
Misses 220 220
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The loop ran as one shell command whose exit code came from its last statement, so a failed i18n_tool, msgcat or mv was swallowed and make exited 0. The daily openedx-translations job could then commit a partial set of source files. Run the loop under set -e, with each step as its own statement so set -e catches it. Same fix as openedx/xblocks-core#329. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: openedx/xblocks-core#241
Follow-up to #35, which changed
make extract_translationsto write onedjango.poper XBlock but left the docs describing the old combined catalog. Same doc updates as openedx/xblocks-core#329.Summary
README.mdanddocs/how-tos/internationalization.rst: describe the per-XBlock output at<module_name>/conf/locale/en/LC_MESSAGES/django.po, and thetranslations/xblocks-extra/<module_name>/conf/locale/layout in openedx-translations. Remove thetext.po, combined-catalog, compile, dummy, validate and Transifex CLI sections, since those targets no longer exist.Makefile: remove the unusedCOMBINED_LOCALE_DIRand a stray space before the tab on themvline.Makefile:extract_translationsnow stops and exits non-zero if any block fails (same fix as build: extract translations per xblock for openedx-translations xblocks-core#329), so the daily openedx-translations job can't commit a partial set of source files.src/freetextresponse/conf/locale/config.yaml: removedummy_locales, since nothing reads it now.How to test
uv run --with edx-i18n-tools make extract_translations(needs GNU gettext)<module_name>/conf/locale/en/LC_MESSAGES/django.poLocal result: same msgid counts as on
mainfor all 7 XBlocks.🤖 Generated with Claude Code