Repository navigation
Expect a joined detail message in commentAfterOpeningDelimiter-assert - #178
Merged
Merged
Conversation
The case came with #175 and ends in the detail message "x below " + "y": two string literals on one line with no comment between them. #176 joins such literals, so the formatter now writes "x below y", and since both were merged every build job of 21.X.X fails on that line. Each had passed on its own, because #176 was tested without the case. The expected output now has the joined literal, as #176 did for the cases of NON-NLS and palantir-10; the input keeps the two literals. Tests on JDK 21: FormatterCasesTest 915 cases, 1482 tests in all modules, none failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
commentAfterOpeningDelimiter-assert.casecame with #175. Its last assert ends in the detail message"x below " + "y": two string literals on one line with no comment between them. #176 joins such literals, so the formatter now writes"x below y", and since both were merged every build job of 21.X.X fails on that case (run 41197372203). Each PR had passed on its own: the head of #176 did not contain #175.The fix
The expected output now has the joined literal, as #176 did for the cases of NON-NLS and palantir-10. The input keeps the two literals.
Tests
On JDK 21,
./gradlew test --rerunis green: FormatterCasesTest 915 cases, 1482 tests in all modules, 14 skipped.