Skip to content

Store dataset reference and organism as lists - #16

Merged
rcannood merged 2 commits into
mainfrom
fix-uns-spec-types
Nov 18, 2026
Merged

rcannood merged 2 commits into
mainfrom
fix-uns-spec-types

Conversation

@rcannood

@rcannood rcannood commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Describe your changes

Make three uns fields match their type in src/api. The component tests don't check types, but a schema generated from the specs (e.g. for LaminDB) would reject every dataset.

  • dataset_reference, dataset_organism: the loaders and workflows take these as multiple: true arguments and store them as lists, since a dataset can have several references and organisms. Tests updated accordingly.
  • The OP3 loader takes --dataset_reference and --dataset_organism instead of hardcoding them (dataset_reference was declared without --, and the organism was written as Homo sapiens instead of homo_sapiens).
  • scicar_cell_lines.ipynb and the v1 multimodal loader pass [homo_sapiens, mus_musculus] as a real list instead of a string.
  • pca_variance: object instead of double. processors/pca writes a dict with variance and variance_ratio.

The test resources on Lamin still have strings here; they get regenerated in #17.

Issue ticket number and link

n/a

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
    • Documentation
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@rcannood rcannood changed the title Fix uns types in the api specs Store dataset reference and organism as lists Nov 18, 2026
@rcannood
rcannood merged commit e4181f5 into main Nov 18, 2026
11 checks passed
@rcannood
rcannood deleted the fix-uns-spec-types branch November 18, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant