Repository navigation
Store the organism per cell in raw scRNA-seq datasets - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Store the organism of raw scRNA-seq datasets per cell, as an ontology term in
obs, instead of as free text inuns.file_raw:obs['organism_ontology_term_id']is required (NCBI Taxonomy), next to the optionalobs['organism']label.uns['dataset_organism']is removed. Per cell, so a dataset can mix organisms.cellxgene_census: fills both columns from--species(homo_sapiens→NCBITaxon:9606,mus_musculus→NCBITaxon:10090);--dataset_organismis removed.cellxgene_census_from_source_h5ad: CELLxGENE schema >= 6.0.0 moved the organism fromobstouns, so it's copied back toobswhen needed;--dataset_organismis removed.openproblems_op3: setsNCBITaxon:9606with the other sample-level ontology terms;--dataset_organismis removed.load_cellxgene_census, thecxg_*notebooks andcreate_resources/cellxgene_census.shno longer passdataset_organism. Test resources regenerated (mouse pancreasAjn1Lo8zZomVzKtQ0004).Multimodal and spatial datasets keep
uns['dataset_organism']until they're migrated. Task repos that readuns['dataset_organism'](e.g. scGPT, Geneformer, UCE, scPRINT and the cell cycle conservation metric in batch integration) will need to switch toobs['organism_ontology_term_id']when they move to the new datasets.Issue ticket number and link
n/a
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!