Skip to content

Fix swapped PCA variance and variance ratio - #21

Merged
rcannood merged 1 commit into
mainfrom
fix-pca-variance
Nov 19, 2026
Merged

rcannood merged 1 commit into
mainfrom
fix-pca-variance

Conversation

@rcannood

Copy link
Copy Markdown
Member

sc.tl.pca(..., return_info=True) returns (X_pca, components, variance_ratio, variance), but processors/pca unpacked the last two the other way around, so uns['pca_variance']['variance'] held the ratios and vice versa.

The test resources still have the swapped values; they get regenerated after #20.

@rcannood
rcannood merged commit c38449b into main Nov 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant