Repository navigation
Conversation
- Drop or-vaadin-tab: or-vaadin-tabs takes vaadin-tab children - Give or-vaadin-tabs the Lumo tabs look through the theme - Move the sliding bar into theme="sliding" variant, with matching bar and tab rounding - Add stories for the Lumo variants, sliding and rounding - Add tests for the variants
Ekhorn
force-pushed
the
feature/add-tabs-component
branch
from
October 23, 2026 07:36
2b4b4d1 to
57ab884
Compare
|
Ekhorn
marked this pull request as ready for review
October 23, 2026 07:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
<or-vaadin-tabs>, a wrapper of Vaadin tabs with the Lumo look, and aslidingvariant: a more mobile-friendly bar where the tabs share the width and an indicator slides behind the selected tab.Changelog
or-vaadin-tabs, which takes<vaadin-tab>children and re-exportsTab@openremote/theme, so the Lumo variants applytheme="sliding"variant, styled through--or-tabs-*propertiesequal-width-tabs@vaadin/tabsresolved to 25.3.3 and pulled in a second copy of the theming packageChecklist