Repository navigation
Rewrite the poster attribute when rewriting HTML - #347
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 2694 2694
Branches 398 398
=========================================
Hits 2694 2694 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The poster attribute (e.g. of <video>) holds a URL like src and href, but it was left as is, so the poster image pointed outside of the ZIM. Fix openzim#339
benoit74
force-pushed
the
rewrite-poster-attribute
branch
from
October 13, 2026 09:54
46ad1d1 to
3889dac
Compare
benoit74
approved these changes
Oct 13, 2026
benoit74
left a comment
benoit74
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you very much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #339
The
posterattribute (e.g. of<video>) holds a URL likesrcandhref, but it was not rewritten, so the poster image pointed outside of the ZIM. It is now handled by the same rule ashrefandsrc.Added
test_rewrite_poster_attribute: absolute URL, alongsidesrc, relative URL with a query, adata:URL that must be kept, and an attribute without a value.