Skip to content

Add push state attributes to repository protocols [IFC-3313] - #1400

Merged
gmazoyer merged 1 commit into
infrahub-developfrom
gma-20261006-ifc-3313
Oct 14, 2026
Merged

gmazoyer merged 1 commit into
infrahub-developfrom
gma-20261006-ifc-3313

Conversation

@gmazoyer

@gmazoyer gmazoyer commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Why

Infrahub adds nine read-only attributes to CoreRepository. They store the state of the pushes that wait for the Git remote, so that a failed push shows on the repository.

protocols.py is generated from the Infrahub core schema. Without these lines, invoke backend.generate in the Infrahub repository leaves the file dirty and the validate-generated job fails.

What changed

  • The nine delivery_* attributes are added to CoreRepository and CoreRepositorySync.

Nothing else. invoke backend.generate in the Infrahub repository renders the file.

How to review

One commit on top of infrahub-develop (7ed9b39), which already has the rewrite record attributes. The Infrahub companion PR points the submodule at this commit.


Summary by cubic

Adds nine read-only delivery_* attributes to the CoreRepository and CoreRepositorySync protocols, so repositories can hold the pending push state and surface failed pushes. protocols.py is generated from the Infrahub core schema; these lines keep the generated file clean and the validate-generated job passing. Part 3 of 5 of IFC-3313, with the companion Infrahub PR at opsmill/infrahub#10987.

Written for commit 4327210. Summary will update on new commits.

View guided diff Turn on auto-fix

Relates to

Infrahub companion PR: opsmill/infrahub#10987 (the push state attributes, part 3 of 5 of IFC-3313)

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4327210
Status: ✅  Deploy successful!
Preview URL: https://e8a5d2e2.infrahub-sdk-python.pages.dev
Branch Preview URL: https://gma-20261006-ifc-3313.infrahub-sdk-python.pages.dev

View logs

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                 Coverage Diff                  @@
##           infrahub-develop    #1400      +/-   ##
====================================================
+ Coverage             86.81%   86.83%   +0.01%     
====================================================
  Files                   152      152              
  Lines                 14763    14781      +18     
  Branches               1982     1982              
====================================================
+ Hits                  12817    12835      +18     
  Misses                 1382     1382              
  Partials                564      564              
Flag Coverage Δ
integration-tests 42.35% <100.00%> (+0.07%) ⬆️
python-3.10 60.91% <100.00%> (+0.03%) ⬆️
python-3.11 60.91% <100.00%> (+0.03%) ⬆️
python-3.12 60.92% <100.00%> (+0.04%) ⬆️
python-3.13 60.91% <100.00%> (+0.04%) ⬆️
python-3.14 60.92% <100.00%> (+0.04%) ⬆️
python-filler-3.12 22.93% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/protocols.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Infrahub adds nine read-only attributes to CoreRepository. They store
the state of the pushes that wait for the remote, so that a failed push
shows on the repository.

This file is generated from the Infrahub core schema. Without these
lines, invoke backend.generate in the Infrahub repository leaves the
file dirty and the validate-generated job fails.
@gmazoyer
gmazoyer force-pushed the gma-20261006-ifc-3313 branch from b37f299 to 0e9497a Compare October 7, 2026 13:23
@gmazoyer
gmazoyer changed the base branch from infrahub-develop to gma-20261006-ifc-3284 October 7, 2026 13:23
Base automatically changed from gma-20261006-ifc-3284 to infrahub-develop October 7, 2026 18:35
@gmazoyer
gmazoyer force-pushed the gma-20261006-ifc-3313 branch from 0e9497a to 9d21dac Compare October 7, 2026 20:42
gmazoyer added a commit to opsmill/infrahub that referenced this pull request Oct 9, 2026
T019 and T026 are done in this PR: the nine attributes and the test of
the mutation inputs are here. T020 stays open and says why: the
generated files are committed, but its SDK gate is open until
opsmill/infrahub-sdk-python#1400 merges and the python_sdk pointer
moves to infrahub-develop.
gmazoyer added a commit to opsmill/infrahub that referenced this pull request Oct 9, 2026
The nine attributes change the core protocols, the GraphQL schema and
the frontend GraphQL types. The python_sdk pointer names the commit
of opsmill/infrahub-sdk-python#1400, which adds the attributes to the
SDK protocols on top of infrahub-develop.
@gmazoyer
gmazoyer force-pushed the gma-20261006-ifc-3313 branch from 9d21dac to 4327210 Compare October 12, 2026 08:00
gmazoyer added a commit to opsmill/infrahub that referenced this pull request Oct 12, 2026
T019 and T026 are done in this PR: the nine attributes and the test of
the mutation inputs are here. T020 stays open and says why: the
generated files are committed, but its SDK gate is open until
opsmill/infrahub-sdk-python#1400 merges and the python_sdk pointer
moves to infrahub-develop.
gmazoyer added a commit to opsmill/infrahub that referenced this pull request Oct 12, 2026
The nine attributes change the core protocols, the GraphQL schema and
the frontend GraphQL types. The python_sdk pointer names the commit
of opsmill/infrahub-sdk-python#1400, which adds the attributes to the
SDK protocols on top of infrahub-develop.
gmazoyer added a commit to opsmill/infrahub that referenced this pull request Oct 12, 2026
The nine attributes change the core protocols, the GraphQL schema and
the frontend GraphQL types. The python_sdk pointer names the commit
of opsmill/infrahub-sdk-python#1400, which adds the attributes to the
SDK protocols on top of infrahub-develop.
@gmazoyer
gmazoyer marked this pull request as ready for review October 14, 2026 15:14
@gmazoyer
gmazoyer requested a review from a team as a code owner October 14, 2026 15:14
@gmazoyer
gmazoyer merged commit 13af0d2 into infrahub-develop Oct 14, 2026
31 checks passed
@gmazoyer
gmazoyer deleted the gma-20261006-ifc-3313 branch October 14, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant