Skip to content

Allow non-sensitive identifiers in logging checks - #9

Open
redhat-chai-bot wants to merge 1 commit into
osac-project:mainfrom
redhat-chai-bot:allow-non-sensitive-log-identifiers
Open

redhat-chai-bot wants to merge 1 commit into
osac-project:mainfrom
redhat-chai-bot:allow-non-sensitive-log-identifiers

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Summary

  • Explicitly allow non-sensitive system IDs and resource names in the sensitive-data logging check.
  • Preserve the existing prohibition on logging sensitive data.

Scope

Only clarifies the logging rule; does not exempt identifiers that contain or expose sensitive information.


AI-generated. Review for accuracy.

@rccrdpccl requested from Slack

Summary

  • Review configuration: The no-sensitive-data-in-logs check now permits non-sensitive system IDs and resource names. It continues to flag logging that may expose passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data.
  • Affected areas: Review configuration only. No changes to API surface, controllers, database, authentication, deployment, CI, tests, or documentation are reported.
  • Compatibility: No runtime compatibility impact is indicated. The review policy changes how the check treats identifiers; identifiers that expose sensitive information remain prohibited.
  • Tests and review findings: No test results or current review findings were supplied.

Risk classification

risk:ask. The labeling criteria classify all .coderabbit.yaml changes as risk:ask because they modify review policy. risk:ship does not apply because .coderabbit.yaml is explicitly excluded. risk:show does not apply because it also excludes .coderabbit.yaml.

Assisted-by: OpenAI Codex <[email protected]>
Signed-off-by: Chai Bot <[email protected]>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Warning

This pull request changes a CodeRabbit configuration file. Because it comes from a fork or its author is not a repository collaborator, reviews use only the configuration from the target branch. The proposed configuration will take effect after it is merged.

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2c193b5 and 147f0a4.

Files selected for processing: 1
  • .coderabbit.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The no-sensitive-data-in-logs pre-merge check instructions now allow non-sensitive system IDs and resource names in logs.

Changes

Logging check

Layer / File(s) Summary
Update allowed log content
.coderabbit.yaml
The no-sensitive-data-in-logs instructions now allow non-sensitive system IDs and resource names.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: risk:ask

Suggested reviewers: sk-ilya

Merge Risk: Minimal · up to 147f0

This change only clarifies the pre-merge logging check so that non-sensitive system IDs and resource names are not flagged. The rule against logging sensitive data stays in place. No merge-blocking risk was found.

Pre-merge checks: Passed 11
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: allowing non-sensitive identifiers in logging checks.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets Passed The pull request changes only .coderabbit.yaml by adding the policy text Allow non-sensitive system IDs and resource names. It introduces no API key, token, password, private key, credential, base…
No-Weak-Crypto Passed The pull request changes only the no-sensitive-data-in-logs instructions in .coderabbit.yaml. It adds an allowance for non-sensitive system IDs and resource names. It introduces no MD5, SHA1, DES,…
No-Injection-Vectors Passed PASS. The pull request changes only one .coderabbit.yaml instruction line, adding an allowance for non-sensitive system IDs and resource names. It introduces no SQL concatenation, shell execution, e…
Container-Privileges Passed PASS. The pull request changes only the no-sensitive-data-in-logs instructions in .coderabbit.yaml. It adds an allowance for non-sensitive system IDs and resource names. It does not add or change …
No-Sensitive-Data-In-Logs Passed PASS: The pull request changes only .coderabbit.yaml and adds an instruction to allow non-sensitive system IDs and resource names. It does not add or modify logging code, and it preserves explicit c…
Ai-Attribution Passed AI use is disclosed in the PR description, and the reviewed commit includes the Red Hat attribution trailer Assisted-by: OpenAI Codex <[email protected]>. No Co-Authored-By trailer appears.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: No-Hardcoded-Secrets

Explanation

The pull request changes only .coderabbit.yaml by adding the policy text Allow non-sensitive system IDs and resource names. It introduces no API key, token, password, private key, credential, base64 blob, embedded-credential URL, or credential-bearing assignment.

Full details: No-Weak-Crypto

Explanation

The pull request changes only the no-sensitive-data-in-logs instructions in .coderabbit.yaml. It adds an allowance for non-sensitive system IDs and resource names. It introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB usage, custom cryptography, or secret comparisons.

Full details: No-Injection-Vectors

Explanation

PASS. The pull request changes only one .coderabbit.yaml instruction line, adding an allowance for non-sensitive system IDs and resource names. It introduces no SQL concatenation, shell execution, eval/exec, pickle or unsafe YAML loading, os.system, or dangerouslySetInnerHTML usage.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only the no-sensitive-data-in-logs instructions in .coderabbit.yaml. It adds an allowance for non-sensitive system IDs and resource names. It does not add or change privileged, host namespace settings, SYS_ADMIN, root execution, or allowPrivilegeEscalation settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only .coderabbit.yaml and adds an instruction to allow non-sensitive system IDs and resource names. It does not add or modify logging code, and it preserves explicit checks for passwords, tokens, API keys, PII, session IDs, internal hostnames, and customer data.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant