Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-7401
Purpose
Viewing a comment whose parent no longer exists gave a 500 error. For comments on works the parent is the chapter, not the parent comment, so this happens when the chapter is gone but the comment is still there. The "Reply" link is built from
comment.parent.id, andadd_comment_reply_linkraisedNoMethodError: undefined method 'id' for nil.This PR:
can_reply_to_comment?return false when the comment has no parent, so the "Reply" link isn't shown.Testing Instructions
The steps in the issue delete the parent comment, which doesn't reproduce the error. These do, and need console access on test:
Comment.find(reply_id).parent.deleteThe comment should be shown with the warning above, and without a "Reply" link.
Credit
Pablo Monfort (he/him)