Skip to content

AB#125030 Drop transport-encoding headers in response. - #218

Merged
buckett merged 2 commits into
masterfrom
AB#125030
Sep 15, 2026
Merged

buckett merged 2 commits into
masterfrom
AB#125030

Conversation

@buckett

@buckett buckett commented May 20, 2026

Copy link
Copy Markdown
Member

If Canvas sends transport encoding headers we should drop them as we will manage our own transport encoding back to the client.

If Canvas sends transport encoding headers we should drop them as we will manage our own transport encoding back to the client.
Copilot AI review requested due to automatic review settings May 20, 2026 09:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Canvas proxy response handling to avoid forwarding upstream transport-level response headers, ensuring this service controls how responses are encoded back to clients.

Changes:

  • Strips Transfer-Encoding from proxied responses (in addition to already stripping Set-Cookie).
  • Adds an inline comment explaining why the header is removed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI commented May 20, 2026

Copy link
Copy Markdown
Contributor

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.jsdelivr.net
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -jar /home/REDACTED/work/tool-support/tool-support/target/surefire/surefirebooter-20260520093500163_3.jar /home/REDACTED/work/tool-support/tool-support/target/surefire 2026-05-20T09-34-59_703-jvmRun1 surefire-20260520093500163_1tmp surefire_0-20260520093500163_2tmp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@buckett
buckett merged commit 3675bd3 into master Sep 15, 2026
1 check passed
@buckett
buckett deleted the AB#125030 branch September 15, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants