Repository navigation
Scene format v1: validation, editor schema and three-room fixture - #1
Merged
Merged
Conversation
This was referenced Oct 25, 2026
WilliamRagstad
marked this pull request as ready for review
October 25, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a minimal, renderer-independent adventure scene contract for the editor. Invalid versions, duplicate IDs, dangling references, invalid hotspot bounds, unknown fields and dialogue nodes without a reliable exit produce actionable diagnostics before a scene can enter the runtime.
Includes a generated JSON Schema with a drift test, editor documentation, a validation CLI and The Last Light: an original, hand-authored three-room fixture. Fixture story, palette and layouts are CC0; font attribution is documented.
Validation:
cargo test --locked(7 tests),cargo clippy --locked --all-targets -- -D warnings,cargo fmt --all -- --check, and fixture validation passed.First of three stacked changes. The runtime branch builds on this PR, followed by save/load and the playable demonstration. Scene validation checks structure and references; it intentionally does not claim to prove puzzle solvability.