Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Add approximate Serbia postal-code points for delivery-to-return distance analysis.
Uses GeoNames RS.zip retrieved 2026-11-04 (CC BY 4.0): 1,155 source rows become 1,149 unique five-digit codes. Each point is the mean of distinct coordinate pairs per code. Coordinates remain strings in [longitude, latitude] order. Unknown codes return undefined. Other countries and normalization stay unchanged.
These are locality representatives, not postal-area centroids. National completeness and independent rural/edge coordinate accuracy are unverified. The official Post of Serbia list confirms the urban postal-code example. No PAK support is included.
Validation: npm test (97 passed), npm run lint, npm run format:check, npm run validate:data passed; data validation retains two existing AUT/BEL warnings. Tests execute all SRB lookups and check unique codes, coordinate bounds, suffix handling, ISO2 lookup, and unknown codes.
Shared-file overlap: one SRB entry in lib/geocode.js. Do not merge automatically.