Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Add Luxembourg postal points for approximate delivery-to-return distance analysis.
Source: official dataset and license, retrieved 2026-11-04. The 179,768 source address rows produce 4,200 unique postal records.
docs/geocode-LUX.mdrecords the snapshot, hashes, method, source checks, and limits. The Python generator uses only the standard library and includes assert-based checks.Evidence
coordinates('LUX', '1135')returnedundefined.After: it returns
['6.112139', '49.611600']in the existing longitude-first string format.npm run lint,npm run format:check, andnpm run validate:datapass. Data validation retains the existing AUT/BEL warnings.Merge Danger
Door: two-way
Blast Radius: LUX
Only LUX data, tests, generator, documentation, and one geocode allowlist entry change. Other country behavior and exports remain unchanged. The allowlist file overlaps other country PRs; retain their entries when resolving conflicts.
The source is incomplete. Points are means of distinct available address positions, not official postal centroids. Six decimal places are storage precision, not guaranteed accuracy. Unknown codes and
L--prefixed input remain unsupported; no fallback center is added. No merge, deployment, or publication is included.