Skip to content

feat: add Luxembourg postal geocoding - #102

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/lux-postal-geocoding
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/lux-postal-geocoding

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

Add Luxembourg postal points for approximate delivery-to-return distance analysis.

ACT BD-Adresses CSV (CC0, 2026-11-02)
  → distinct coordinate pairs per postal code
  → mean WGS84 point
  → 4,200 full postal-code lookups

Source: official dataset and license, retrieved 2026-11-04. The 179,768 source address rows produce 4,200 unique postal records. docs/geocode-LUX.md records the snapshot, hashes, method, source checks, and limits. The Python generator uses only the standard library and includes assert-based checks.

Evidence

  • Before: LUX was unsupported; coordinates('LUX', '1135') returned undefined.
    After: it returns ['6.112139', '49.611600'] in the existing longitude-first string format.
  • 98 tests pass, including full dataset checks and actual LUX lookups for Luxembourg, Hupperdange, and Wemperhardt.
  • npm run lint, npm run format:check, and npm run validate:data pass. Data validation retains the existing AUT/BEL warnings.

Merge Danger

Door: two-way

Blast Radius: LUX

Only LUX data, tests, generator, documentation, and one geocode allowlist entry change. Other country behavior and exports remain unchanged. The allowlist file overlaps other country PRs; retain their entries when resolving conflicts.

The source is incomplete. Points are means of distinct available address positions, not official postal centroids. Six decimal places are storage precision, not guaranteed accuracy. Unknown codes and L--prefixed input remain unsupported; no fallback center is added. No merge, deployment, or publication is included.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:03:37.609975Z 7319519 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant