Skip to content

fix: refresh BEL postal-code representative points - #103

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/bel-geocode-20261104
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/bel-geocode-20261104

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

Update BEL postal-code points for approximate delivery-to-return distance analysis.

GeoNames BE.txt (2,781 rows)
  → distinct coordinate pairs per postal code
  → unweighted mean, rounded to six decimals
  → 1,146 full-postcode points

Use GeoNames BE.zip retrieved 2026-11-04 (export timestamp 2026-11-04), licensed CC BY 4.0. Source attribution, hash, regeneration command, primary-source locality checks, and coverage limits are in docs/geocode-BEL.md. No runtime, export, type, or other-country change.

Evidence

  • Before: 3,386 rows / 1,175 codes; duplicate codes returned the first locality.
    After: 1,146 unique codes; 516 codes with multiple distinct points use a deterministic mean without duplicate-row weighting. Returns remain string [longitude, latitude].
  • npm test: 98 passed, including all BEL lookups, known urban/rural/edge points, supported code-plus-town input, and unknown/unsupported formats.
  • npm run lint, npm run format:check, npm run validate:data: passed. Data validation retains two existing unused-region-name warnings.
  • Generator assertions verify duplicate/order invariance, code format, and finite coordinate ranges.

Merge Danger

Door: two-way

Revert restores the old dataset. No publish, deployment, or merge is part of this request.

Blast Radius: BEL

29 legacy codes absent from the current source now return undefined; the complete list is in the source notes. This does not mean those codes are invalid. Source coverage is partial, and coordinates are estimated locality means, not postal-area centroids or address points. No measured accuracy bound is available. Primary-source checks confirm code/locality associations, not independent coordinate accuracy. No shared runtime files overlap other country PRs.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:03:43.411497Z 9d1f93f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant