Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Add full five-digit KOR postal coordinate lookup for approximate return-distance analysis.
Source: https://download.geonames.org/export/zip/KR.zip, retrieved 2026-11-04; archive member dated 2026-11-04. GeoNames CC BY 4.0 attribution and source checksum are in
docs/geocode-KOR.md. This is not an official Korea Post extract. National completeness and distance error bounds are unverified. Points are representatives, not measured postal centroids. Duplicate source rows do not add weight.Evidence
undefinedbecause it was not in the geocode allowlist.coordinates('KOR', '04524')returns['126.9777', '37.5662']; missing codes still returnundefined. Existing normalization, coordinate string type, exports and other countries remain unchanged.npm test(99 tests),npm run lint,npm run format:check,npm run validate:data; generator assertions also passed.Merge Danger
Door: two-way
Blast Radius: KOR
Adds one geocode allowlist entry plus KOR data, tests, generator and source notes.
lib/geocode.jsmay overlap with other country PRs. No dependencies, generic normalization changes, fraud decisions, publication or deployment. Do not merge as part of this task.