Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Add Hungary postal geocoding for approximate delivery-to-return distance analysis.
Source: GeoNames HU.zip, retrieved 2026-11-04, export timestamp 2026-11-04. CC BY 4.0, with attribution and source hashes in
docs/geocode-HUN.md. The generator combines 3,571 locality rows into 3,046 unique codes by averaging distinct coordinate pairs. Duplicate source rows do not add weight.This provides approximate locality points, not postal-area centroids. Complete national coverage and coordinate error bounds are unverified. Budapest codes can share a city point. Primary postal/municipal sources confirm urban, rural and border sample code associations; they do not independently certify coordinate precision.
HUN accepts a full four-digit code and surrounding whitespace. Unknown or malformed codes return
undefined. Coordinate strings and[longitude, latitude]order match existing behavior. Other countries retain their behavior. No dependency, export, type or region-data change.Evidence
undefined.1014,9945,3999, shared code7370, aliases, whitespace, malformed codes and unknown codes. All 3,046 points pass format, uniqueness and finite coordinate bounds checks.npm test: 99 passed.npm run lint,npm run format:check,npm run validate:data: passed. Data validation retains two existing AUT/BEL warnings.Merge Danger
Door: two-way
Blast Radius: HUN
Changes can be reverted without data migration. Approximate points can give inaccurate distances, especially within Budapest and shared rural postal areas. The package audit reports seven existing dependency findings (six moderate, one high); dependencies are unchanged.
lib/geocode.jsoverlaps with concurrent country PRs. Preserve all country entries and country-specific normalization during conflict resolution. This PR starts from default-branch commit8a7bd9b2941b5c094a2707e8f386c18286d8318c; no other country PR was merged into the branch. No merge, publish, deployment or production write was performed.