Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Add approximate postal-code lookup for Japan for return-location distance analysis.
Source: GeoNames JP.zip, retrieved 2026-11-04, export dated 2026-11-04, CC BY 4.0. The 146,883 source rows cover 47 prefecture entries. Duplicate coordinate pairs are removed; 16 multi-point codes use an unweighted mean of distinct points. Source, license, checksum, generation steps, and Japan Post assignment checks are in
docs/geocode-JPN.md.This is source coverage, not complete national coverage. GeoNames points are estimates, often shared across locality codes. Four decimals do not establish accuracy. No measured distance-error bound is available. These are not postal-area centroids or scan/building locations.
Evidence
undefined.After:
coordinates('JPN', '100-0001')returns['139.7521', '35.6841'].npm test: 99 pass.npm run lint,npm run format:check, andnpm run validate:data: pass. Data validation retains the two existing AUT/BEL warnings.Merge Danger
Door: two-way
Blast Radius: JPN
The shared
lib/geocode.jsallowlist and normalization lines can overlap with concurrent country PRs. Only JPN changes are included. The dataset adds about 12.2 MB of JSON and lookup retains the existing linear scan. No merge, publication, or deployment is included.