Skip to content

feat: add Romanian postal coordinate lookup - #112

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/geocode-rou-20261104
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/geocode-rou-20261104

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

Add approximate Romanian postal coordinates for return-location distance analysis.

coordinates(ROU, full postal code)
  trim surrounding whitespace
  look up 37,914 unique codes
  return [longitude, latitude] strings

GeoNames RO.zip, retrieved 2026-11-04, is licensed CC BY 4.0. Its 37,915 rows become 37,914 codes. Code 510002 uses the unweighted mean of distinct source points. See docs/geocode-ROU.md for attribution, checksum, generation, official postal sample checks and limits. Coverage is not proven complete. Points represent estimated localities, not street locations or postal-area centroids.

Evidence

  • Before: ROU is unsupported and coordinate lookup returns undefined.
    After: Offline lookup tests pass for Bucharest, Craiova, rural Crișan, leading zeros, aliases, surrounding whitespace, repeated-code aggregation and unknown/malformed codes.
  • All 99 tests pass. Lint and format checks pass. Data validation passes with two existing AUT/BEL warnings.
  • The generator validates code format, finite coordinate ranges, expected count and the repeated-code mean.

Merge Danger

Door: two-way

Blast Radius: ROU

Only ROU data and normalization change. The shared lib/geocode.js allowlist can conflict with concurrent country PRs. Other country behavior, exports and types remain unchanged. No merge or publication is requested. Source coordinates have no verified distance-error bound; many urban codes share points.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:04:13.266471Z 8fa4cb5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant