Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Add approximate Romanian postal coordinates for return-location distance analysis.
GeoNames RO.zip, retrieved 2026-11-04, is licensed CC BY 4.0. Its 37,915 rows become 37,914 codes. Code 510002 uses the unweighted mean of distinct source points. See docs/geocode-ROU.md for attribution, checksum, generation, official postal sample checks and limits. Coverage is not proven complete. Points represent estimated localities, not street locations or postal-area centroids.
Evidence
After: Offline lookup tests pass for Bucharest, Craiova, rural Crișan, leading zeros, aliases, surrounding whitespace, repeated-code aggregation and unknown/malformed codes.
Merge Danger
Door: two-way
Blast Radius: ROU
Only ROU data and normalization change. The shared lib/geocode.js allowlist can conflict with concurrent country PRs. Other country behavior, exports and types remain unchanged. No merge or publication is requested. Source coordinates have no verified distance-error bound; many urban codes share points.