Skip to content

feat: add Irish routing-key coordinate lookup - #113

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/irl-routing-key-geocodes
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/irl-routing-key-geocodes

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

Add coarse Irish postal geocoding for return-location analysis.

IRL routing key or full Eircode
  validate and normalize IRL input
  look up 139 GeoNames routing-key place points
  return [longitude, latitude] strings or undefined

Source: GeoNames IE.zip, retrieved 2026-11-04, dump dated 2026-11-04, CC BY 4.0. There are 139 records and 139 unique keys. These are named-place points, not routing-area centroids or address coordinates. Coverage is partial: A65 is absent. No missing points were generated. See docs/geocode-IRL.md for attribution, source hash, primary-source checks and precision limits.

Only IRL is added to the geocode allowlist. IRL accepts routing keys and spaced/compact full Eircodes, including lowercase input and D6W. Leading zeros remain intact. Other countries, exports and coordinate types retain their existing behavior. Shared-file overlap: lib/geocode.js.

Evidence

  • Before: IRL is unsupported and returns undefined.
    After: offline tests execute all 139 lookups and cover formats, D6W, D01 zeros, urban/rural/north-west examples, missing A65, unknown keys, malformed suffixes, uniqueness and coordinate ranges.
  • npm test: 99 passed.
  • npm run lint, npm run format:check, npm run validate:data: passed. Data validation has two existing AUT/BEL warnings.
  • No new dependencies. Shared project checkout was not changed.

Merge Danger

Door: two-way

Blast Radius: IRL

Routing-key points can have substantial distance error. Distinct addresses with the same key return the same point. Full Eircode syntax does not validate address existence. No exact address accuracy, complete coverage, or measured distance-error guarantee. No merge, deployment or publication is included.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:04:22.963379Z a02b6c7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant