Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Add coarse Irish postal geocoding for return-location analysis.
Source: GeoNames IE.zip, retrieved 2026-11-04, dump dated 2026-11-04, CC BY 4.0. There are 139 records and 139 unique keys. These are named-place points, not routing-area centroids or address coordinates. Coverage is partial: A65 is absent. No missing points were generated. See
docs/geocode-IRL.mdfor attribution, source hash, primary-source checks and precision limits.Only IRL is added to the geocode allowlist. IRL accepts routing keys and spaced/compact full Eircodes, including lowercase input and D6W. Leading zeros remain intact. Other countries, exports and coordinate types retain their existing behavior. Shared-file overlap:
lib/geocode.js.Evidence
After: offline tests execute all 139 lookups and cover formats, D6W, D01 zeros, urban/rural/north-west examples, missing A65, unknown keys, malformed suffixes, uniqueness and coordinate ranges.
npm test: 99 passed.npm run lint,npm run format:check,npm run validate:data: passed. Data validation has two existing AUT/BEL warnings.Merge Danger
Door: two-way
Blast Radius: IRL
Routing-key points can have substantial distance error. Distinct addresses with the same key return the same point. Full Eircode syntax does not validate address existence. No exact address accuracy, complete coverage, or measured distance-error guarantee. No merge, deployment or publication is included.