Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Return-location analysis needs approximate postcode points. AUS previously returned
undefinedfor every coordinate lookup. This adds 3,044 distinct full-postcode points, with leading zeros retained.Source: GeoNames AU.zip, retrieved/exported 2026-11-04, CC BY 4.0. Input: 18,566 locality rows / 3,170 codes. Retain 16,443 rows at accuracy 4 or 6, then average distinct coordinate pairs per postcode without duplicate-row weighting. Output: 3,044 records / unique postcodes. Source, hash, regeneration, attribution, primary-source sample checks, and limits are in
docs/geocode-AUS.md.This is incomplete coverage. Estimated rows (levels 1–3) are excluded, including mainland points incorrectly assigned to Norfolk, Christmas, and Cocos Islands. Rural points can be far from towns: the Birdsville sample is about 53 km from the Queensland Government town-area reference. Means are not official postal centroids or physical scan locations; no distance or fraud product is added.
Evidence
After: actual lookup tests pass for Darwin 0800, Sydney 2000, Birdsville 4482, and Lord Howe 2898, with all 3,044 records checked through the runtime lookup.
npm run lint,npm run format:check, andnpm run validate:datapass; validation retains two existing AUT/BEL warnings.Merge Danger
Door: two-way
Blast Radius: AUS
Only AUS data, generation, documentation, tests, and required runtime wiring change. Existing countries, exports, and coordinate string behavior stay unchanged.
lib/geocode.jsoverlaps other country work; preserve all country entries when resolving conflicts. No merge, deployment, or publish is requested. Coverage is partial and rural accuracy has no guaranteed error bound.