Skip to content

feat: add Poland postal geocoding - #120

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/pol-postal-geocoding
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/pol-postal-geocoding

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

Add approximate Poland postal geocoding for return-location distance analysis. October 2026 parcelLab analysis observed 301,331 provider-coded return tracking records with destination POL; this is observed parcelLab volume, not national market share.

coordinates(POL, 00-002 | 00002 | 00 002)
  → normalize Polish postcode
  → full postcode point [longitude, latitude] as strings

GeoNames PL export dated/retrieved 2026-11-04, CC BY 4.0: 72,899 source rows become 20,299 unique postcodes. Each point is the mean of distinct coordinate pairs; duplicate rows have no extra weight. Source, hashes, reproduction, primary sample checks and limits: docs/geocode-POL.md.

Coverage is partial (00-001 is absent). These are approximate representatives, not postal-area centroids or parcel positions. Rural uncertainty can span many kilometres. Six decimals do not imply measured accuracy. Primary checks confirm sample postcode/locality associations, not surveyed coordinates.

Evidence

  • Before: POL was unsupported by the geocode allowlist.
    After: offline public-lookup tests cover leading zeros, compact/spaced forms, country aliases, urban/rural/border samples, malformed/unknown codes, uniqueness and finite ranges. Legacy DEU behavior is checked.
  • All 99 tests pass. npm run lint, npm run format:check, and npm run validate:data pass; validation reports two existing AUT/BEL warnings.
  • Country-scoped generator includes assertion checks for format/ranges and duplicate-independent aggregation.

Merge Danger

Door: two-way

Blast Radius: POL

Only geocoding data and Poland-specific wiring change. Static regions, exports, coordinate return types and other-country normalization remain unchanged. Concurrent country PRs can overlap in lib/geocode.js; retain all country allowlist/normalization changes when resolving conflicts. No merge, package publication or deployment is included.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:19:10.695814Z e724cb7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant