Skip to content

feat: add Danish postal geocoding - #121

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/geocode-dnk
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/geocode-dnk

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

DNK currently has no postal geocoding. Add 1,159 full four-digit postal points from GeoNames DK.zip, retrieved 2026-11-04 (export modified 2026-11-04), under CC BY 4.0 with attribution and source hash in docs/geocode-DNK.md.

coordinates(DNK, postcode)
  trim outer whitespace and optional DK-/DK prefix
  exact postcode lookup → [longitude, latitude] strings

All 1,159 source rows are unique, so no aggregation is needed. Points are approximate; coverage is not proven complete and 122 source accuracy fields are empty. Municipal checks confirm Ærøskøbing and Skagen postcode/locality pairs, not exact centroid positions. No distance error bound is claimed.

Evidence

  • Before: DNK returns undefined as an unsupported country.
  • After: 1050, DK-1050, dk1050, and outer whitespace resolve to ['12.5857', '55.6806']; unknown and malformed codes return undefined.
  • All 98 tests pass, including full dataset lookup, unique codes, finite/range validation, islands, and unknown codes.
  • npm run lint, npm run format:check, and npm run validate:data pass. The validator retains two existing AUT/BEL warnings.

Merge Danger

Door: two-way

Blast Radius: DNK

No region mappings or lib/region.js changes. Other-country normalization and string coordinate return types stay unchanged. lib/geocode.js overlaps concurrent country PRs; preserve their allowlist additions when resolving conflicts. No merge, publication, or deployment is part of this PR.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:19:01.818138Z 8ed3d30 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant