Skip to content

fix: refresh Austrian postal-code representative points - #96

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/aut-postal-geocodes
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/aut-postal-geocodes

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

Support approximate delivery-to-return distance analysis with an updated AUT postal dataset.

GeoNames AT: 19,225 locality rows
  → distinct coordinate pairs per postal code
  → arithmetic mean, four decimal places
  → 2,501 unique postal-code records

Source: https://download.geonames.org/export/zip/AT.zip, retrieved 2026-11-04; export Last-Modified 2026-11-04. GeoNames CC BY 4.0. Attribution, checksum, reproduction command and primary postal/locality checks are in docs/geocode-AUT.md.

Retain string coordinates, longitude/latitude order and existing input behavior. No runtime or shared-file edits. No other country changes.

Evidence

  • Before: 19,055 rows, 2,215 unique codes; lookup used the first locality.
  • After: 2,501 unique codes; duplicate source coordinates have no extra weight. All 2,501 actual lookups tested, with urban Vienna, rural Obertilliach and border Riezlern examples.
  • Passed: npm test (98 tests), npm run lint, npm run format:check, npm run validate:data. Data validation has two existing unused-region warnings.
  • Generator self-check passed for duplicate removal, arithmetic mean and a synthetic leading zero.

Merge Danger

Door: two-way

Blast Radius: AUT

Existing AUT coordinates can move. These are approximate representative points, not postal-area centroids. GeoNames can infer coordinates from neighboring codes; complete active-code coverage and positional error are unverified. The source associates 1300 with Mannswörth, not the airport terminal. No fraud decision logic. No merge, publish or deployment requested.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:03:12.595403Z 16de9dc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant