Skip to content

fix: refresh DEU postal geocoding points - #98

Closed
jkrenge wants to merge 1 commit into
masterfrom
codex/deu-geocode-refresh
Closed

jkrenge wants to merge 1 commit into
masterfrom
codex/deu-geocode-refresh

Conversation

@jkrenge

@jkrenge jkrenge commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.


Summary

Return-location distance analysis needs representative German postal-code points. The old lookup selected the first locality, and two records contained latitude 14612.

GeoNames DE.txt (23,296 locality rows)
  distinct coordinate pairs per postal code
  unweighted coordinate mean
  DEU.json (10,815 unique five-digit codes)

Refresh only DEU data using the 2026-11-04 GeoNames postal export, licensed CC BY 4.0 with attribution in docs/geocode-DEU.md. Include a country-specific generator with assertions, offline lookup tests and source/accuracy notes. Keep coordinate strings, [longitude, latitude], exports and normalization unchanged.

Evidence

  • Before: 16,485 rows, 8,311 unique codes; 01945 selected the first locality [14, 51.4333].
  • After: 10,815 rows and unique codes; 01945 uses the mean of distinct source points [13.878122, 51.419711].
  • Added 2,516 codes; removed 12 codes absent from the source, listed in the source note. Removed codes now return undefined.
  • All 98 tests pass. npm run lint, npm run format:check and npm run validate:data pass. Data validation retains two existing AUT/BEL warnings. Generator assertions pass.
  • Primary municipal/statistical sources confirm sample postal-code/locality pairs for Dresden, Helgoland and Oberstdorf. Exact postal boundaries and coordinate accuracy are not independently certified.

Merge Danger

Door: two-way. Static data can be reverted.

Blast Radius: DEU. Coordinate values change and 12 legacy lookups become misses. These are approximate WGS84 representative points, not postal-area centroids or scan-site coordinates. National completeness, PO boxes and special recipient codes are not verified. No other country data or runtime changes. The one DEU assertion in test/tests.js overlaps a shared test file; other files are country-specific. No merge or deployment requested.

@jkrenge
jkrenge requested a review from a team as a code owner November 4, 2026 22:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T22:03:33.102691Z 0221eff PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jkrenge jkrenge closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant