Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Return-location distance analysis needs representative German postal-code points. The old lookup selected the first locality, and two records contained latitude
14612.Refresh only DEU data using the 2026-11-04 GeoNames postal export, licensed CC BY 4.0 with attribution in docs/geocode-DEU.md. Include a country-specific generator with assertions, offline lookup tests and source/accuracy notes. Keep coordinate strings,
[longitude, latitude], exports and normalization unchanged.Evidence
01945selected the first locality[14, 51.4333].01945uses the mean of distinct source points[13.878122, 51.419711].npm run lint,npm run format:checkandnpm run validate:datapass. Data validation retains two existing AUT/BEL warnings. Generator assertions pass.Merge Danger
Door: two-way. Static data can be reverted.
Blast Radius: DEU. Coordinate values change and 12 legacy lookups become misses. These are approximate WGS84 representative points, not postal-area centroids or scan-site coordinates. National completeness, PO boxes and special recipient codes are not verified. No other country data or runtime changes. The one DEU assertion in test/tests.js overlaps a shared test file; other files are country-specific. No merge or deployment requested.