Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
The return-location distance use case needs approximate postal-code points. Spain previously returned the first locality for repeated codes.
Use the 2026-11-04 GeoNames ES export (CC BY 4.0) and store one point for each of 11,150 postal codes, derived from 37,867 source rows. Average distinct coordinate pairs per code so repeated aliases do not add weight. Preserve string coordinates, leading zeros, existing parsing, and
[longitude, latitude]order. No runtime or other-country changes.These are estimated locality representative points, not postal-area centroids. National completeness and a positional error bound are not established. Source, license, archive checksum, rebuild instructions, primary-source postal association checks, and limits are in docs/geocode-ESP.md.
Validation: all 98 tests pass; lint, format:check, validate:data, and diff whitespace checks pass. Data validation retains two existing AUT/BEL warnings. ESP tests cover mainland, islands, autonomous cities, leading zeros, unknown codes, uniqueness, bounds, and a multiple-locality mean. The generator checks duplicate weighting with assertions.
No merge or deployment. No shared runtime-file overlap with other country work.