Skip to content

feat(krater): expect alastor's edge ping on production - #110

Merged
jaspermayone merged 2 commits into
mainfrom
claude/krater-edge-ping-expected-prod
Nov 16, 2026
Merged

jaspermayone merged 2 commits into
mainfrom
claude/krater-edge-ping-expected-prod

Conversation

@jaspermayone

Copy link
Copy Markdown
Member

This turns on KRATER_EDGE_PING_EXPECTED for Krater production, the last step of the rollout in patchworklabsorg/krater#84. Staging has had it since #108 and #109.

Why now:

  • Production runs krater#84 (6e5a81f).
  • alastor pings https://krater.patchworklabs.org/healthz/edge every minute (feat(alastor): ping krater's /healthz/edge every minute #107), and it returns 200.
  • In the 40 minutes before this PR, the production ping missed twice, each time alone: once during a production deploy restart, once from a connection reset. Krater holds actions only after 4 minutes with no ping and alerts after 10, so single misses do nothing.

What changes:

  • hosts/weft/krater.nix: production's extraEnv gets KRATER_EDGE_PING_EXPECTED = "true".
  • tests/krater-weft.nix:
    • production expects the ping, in the option and in the rendered worker command;
    • a new check fails if alastor's kraterEdgePing is off while either Krater deployment expects the ping.

Deploy: weft follows main, so the merge is the deploy. The production worker restarts on the switch and reads the setting. The production portal does not restart.

Known risk: production now depends on alastor. If alastor is down for more than 4 minutes while a runner is also silent, Krater holds the stop and the machine keeps billing, for at most 6 hours. That is the design of krater#83. After a long alastor rebuild, check /admin for network_hold events.

Tested: nix fmt is clean, and the krater-weft check evaluates. It could not build on remus, because the x86_64-linux builder is down. CI runs it. An adversarial review found no high or medium issues. Its test gap finding is fixed in the second commit.

@jaspermayone
jaspermayone requested a review from a team November 16, 2026 16:09
@jaspermayone
jaspermayone merged commit 03429eb into main Nov 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant