Repository navigation
feat(krater): expect alastor's edge ping on production - #110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns on
KRATER_EDGE_PING_EXPECTEDfor Krater production, the last step of the rollout in patchworklabsorg/krater#84. Staging has had it since #108 and #109.Why now:
6e5a81f).https://krater.patchworklabs.org/healthz/edgeevery minute (feat(alastor): ping krater's /healthz/edge every minute #107), and it returns 200.What changes:
hosts/weft/krater.nix: production'sextraEnvgetsKRATER_EDGE_PING_EXPECTED = "true".tests/krater-weft.nix:kraterEdgePingis off while either Krater deployment expects the ping.Deploy: weft follows
main, so the merge is the deploy. The production worker restarts on the switch and reads the setting. The production portal does not restart.Known risk: production now depends on alastor. If alastor is down for more than 4 minutes while a runner is also silent, Krater holds the stop and the machine keeps billing, for at most 6 hours. That is the design of krater#83. After a long alastor rebuild, check
/adminfornetwork_holdevents.Tested:
nix fmtis clean, and thekrater-weftcheck evaluates. It could not build on remus, because thex86_64-linuxbuilder is down. CI runs it. An adversarial review found no high or medium issues. Its test gap finding is fixed in the second commit.