Repository navigation
fix: delete finished job rows after one day - #298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GHSA-3rx4-8wxp-j549, which names this gap.
Problem
A finished Solid Queue job row keeps the job arguments. For a magic link or a guardian consent email, the arguments include the raw link token. Nothing deleted finished job rows, and
/admin/jobsshows them.Change
config/recurring.yml: a new task,clear_finished_jobs, runsSolidQueue::Job.clear_finished_in_batcheseach hour.config/application.rb:config.solid_queue.clear_finished_jobs_after = 1.day. This is the gem default. The line makes the retention time visible.spec/config/recurring_spec.rb: checks each entry ofconfig/recurring.ymlfor a schedule that Solid Queue can read, known keys, and a job class or command method that exists.Effects to know
/admin/jobsshows finished jobs for one day only.break_glass_board_report, shows no last run after one day.Checks
bundle exec rspec: full suite, 0 failures. The rewritten spec file alone: 60 examples, 0 failures.bin/rubocop: no offenses.bin/brakeman: 0 warnings.