Repository navigation
fix: patch vulnerable gems and update all gems - #300
Open
jaspermayone wants to merge 2 commits into
Open
jaspermayone wants to merge 2 commits into
jaspermayone wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes the 44 open Dependabot alerts and 5 code scanning alerts.
38c9356updates only the vulnerable gems, withbundle update --conservative: Rails 8.1.4.1, rack 3.2.8, nokogiri 1.19.7, loofah 2.25.3, crass 1.0.8, addressable 2.9.2, msgpack 1.8.7 and rails-html-sanitizer 1.7.2. This closes the critical Active Storage alert (Verify github student status via api #109) and all the high alerts.4185c0frunsbundle update --allwithin the Gemfile constraints. This covers the 10 open Dependabot PRs (chore(deps): bump webauthn from 3.4.3 to 3.5.0 #259 to chore(deps): bump phonelib from 0.10.28 to 0.11.0 #272) and 30 other updates. The larger ones are prism 2.1, phonelib 0.11, fx 0.13, webauthn 3.5.1, omniauth 2.4.2 and puma 8.1.2.ci.ymlnow setspermissions: contents: read. This closes code scanning alerts Shipping notes #14 to Add activity feed API #17.Api::V1::HealthControllerno longer skips the CSRF check. The route is GET only, so the skip did nothing. This closes alert add - Phone number (with area code) #11.Checks
bundle exec rspec: 2886 examples, 0 failures, after each commit.bin/rubocop: no offenses.bin/brakeman: no warnings.bin/rails zeitwerk:check: passed.Test on staging
The specs use fakes for these paths, so test them on staging after the merge:
The first Alpine image build is the real check that the prism 2.1 musl gem installs.