Repository navigation
Fix security alerts: patched gems, CI permissions, health CSRF skip - #302
Open
Adambomb210 wants to merge 1 commit into
Open
Adambomb210 wants to merge 1 commit into
Adambomb210 wants to merge 1 commit into
Conversation
…ions, drop CSRF skip on health Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the open Dependabot and code-scanning alerts on
main.Dependabot (44 alerts):
Gemfile.lockonly. The Gemfile is unchanged, and nothing else was upgraded.safe_constantizeDoS.BUNDLED WITHis still 4.0.23.Code scanning
ci.ymldeclarespermissions: contents: readat the top. None of its jobs write anything.skip_before_action :verify_authenticity_tokenfromApi::V1::HealthController. The route is GET only, and Rails never checks CSRF on GET, so behavior is unchanged. Newspec/requests/api/v1/health_spec.rbchecks that it still answers 200 without sign-in.users_controller.rb:112): false positive, no code change. CodeQL is matching the namebilling_address_attributes. That is a postal address (UserAddress) with no card or bank data, stored the same way as the shipping address. To be dismissed as a false positive.Tested in Docker (ruby 4.0.7, postgres 17):
db:schema:load,zeitwerk:checkand boot all pass.rspec spec/requests/api spec/controllersran 124 examples with 1 failure,shipping_address_spec.rb:168, becausetailwind.csswasn't built in the container. That's an asset build issue, not these changes. The full suite wasn't run locally, andci.ymldoesn't run rspec.🤖 Generated with Claude Code