Skip to content

Fix security alerts: patched gems, CI permissions, health CSRF skip - #302

Open
Adambomb210 wants to merge 1 commit into
mainfrom
claude/security-alerts
Open

Adambomb210 wants to merge 1 commit into
mainfrom
claude/security-alerts

Conversation

@Adambomb210

Copy link
Copy Markdown
Collaborator

Fixes the open Dependabot and code-scanning alerts on main.

Dependabot (44 alerts): Gemfile.lock only. The Gemfile is unchanged, and nothing else was upgraded.

  • rails 8.1.4 → 8.1.4.1, with all of its components. This fixes the critical Active Storage arbitrary file read/write and the high-severity remote code execution in video previews, Strong Parameters bypass, RemoteIp spoofing and safe_constantize DoS.
  • rack 3.2.7 → 3.2.8, loofah 2.25.2 → 2.25.3, nokogiri 1.19.4 → 1.19.7 (all 7 platforms kept), addressable 2.9.0 → 2.9.2, crass 1.0.7 → 1.0.8, rails-html-sanitizer 1.7.1 → 1.7.2, msgpack 1.8.5 → 1.8.7.
  • PLATFORMS is unchanged, and BUNDLED WITH is still 4.0.23.

Code scanning

  • Shipping notes #14–Add activity feed API #17 (missing workflow permissions): ci.yml declares permissions: contents: read at the top. None of its jobs write anything.
  • add - Phone number (with area code) #11 (CSRF disabled): removed skip_before_action :verify_authenticity_token from Api::V1::HealthController. The route is GET only, and Rails never checks CSRF on GET, so behavior is unchanged. New spec/requests/api/v1/health_spec.rb checks that it still answers 200 without sign-in.
  • tmp #7 (clear-text storage, users_controller.rb:112): false positive, no code change. CodeQL is matching the name billing_address_attributes. That is a postal address (UserAddress) with no card or bank data, stored the same way as the shipping address. To be dismissed as a false positive.

Tested in Docker (ruby 4.0.7, postgres 17): db:schema:load, zeitwerk:check and boot all pass. rspec spec/requests/api spec/controllers ran 124 examples with 1 failure, shipping_address_spec.rb:168, because tailwind.css wasn't built in the container. That's an asset build issue, not these changes. The full suite wasn't run locally, and ci.yml doesn't run rspec.

🤖 Generated with Claude Code

…ions, drop CSRF skip on health

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@Adambomb210
Adambomb210 requested a review from a team November 19, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant