Repository navigation
fix: critical update banner for Windows <=5.2.0 - #742
Merged
Merged
Conversation
|
Windows builds below 5.3.0 have a critical stability issue. Show a bottom banner on those installs pointing users to phcode.io to download a current build. Scoped to PLATFORM "win" only. Below 5.2.5 the banner shows on every boot and omits notification_ack, so it keeps reappearing until the user updates. From 5.2.5 up to 5.3.0 the normal auto-update path works, so the banner is shown just once. Translations for de, fr, it, ja, ko and pt-BR are hand-written here rather than waiting on the auto-translation action, since this is urgent. Claude-Session: https://claude.ai/code/session_011ifem1U6QZyHLTLs8EVitr Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
abose
force-pushed
the
critical-windows-update-banner
branch
from
October 28, 2026 07:32
bd5d91f to
44d33e4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
CRITICAL_WINDOWS_UPDATE_5_2_0banner notification todocs/appNotifications/prod, shown only on Windows desktop installs at version<=5.2.0, directing users to phcode.io to download a current build.Banner
The Download button calls
Phoenix.app.openURLInDefaultBrowser('https://phcode.io'), matching the existing lifetime-deal banner.Config
PLATFORMwin— Windows desktop onlyFOR_VERSIONS<=5.2.0DANGER_SHOW_ON_EVERY_BOOTtrueUSER_TYPENo
notification_ackclass, so clicking Download does not suppress the banner. It reappears every launch until the user actually updates past 5.2.0.Translations
de, fr, it, ja, ko and pt-BR are hand-written in this PR rather than left to the auto-translation action, so the banner ships fully localized without waiting for a follow-up bot PR. All 7 files validated as parseable JSON.
Deploying
Per
docs/appNotifications/readme.md, merging tomainis not sufficient —mainmust then be merged into theupdate-notificationsbranch to push this to the installed base.🤖 Generated with Claude Code
https://claude.ai/code/session_011ifem1U6QZyHLTLs8EVitr