Repository navigation
Remove duplicate pl-oauth-config ConfigMap from public cloud deps - #2411
Merged
vihangm merged 1 commit intoOct 25, 2026
Merged
Conversation
The pl-oauth-config ConfigMap was defined both in k8s/cloud_deps/public/configs.yaml and in k8s/cloud/base/ory_auth/oauth_config.yaml, with identical data. The self-hosted install applies cloud_deps first and cloud afterwards, so the copy in cloud_deps is always overwritten and never takes effect. None of the cloud_deps resources consume it either; only the auth server and cloud proxy in k8s/cloud do. The duplicate also breaks anyone combining the released cloud_deps.yaml and cloud.yaml bundles in a single kustomization: may not add resource with an already registered id: ConfigMap.v1.[noGrp]/pl-oauth-config.plc Drop the ConfigMap from cloud_deps and carry its explanatory comment over to the ory_auth definition, which is the one that is actually deployed (and the only one used by the dev cloud_deps overlay as well). Fixes pixie-io#1840 Signed-off-by: NopeCharon <[email protected]>
vihangm
approved these changes
Oct 25, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Remove the duplicate
pl-oauth-configConfigMap from the public cloud depspl-oauth-configis defined twice with identical data: ink8s/cloud_deps/public/configs.yamland ink8s/cloud/base/ory_auth/oauth_config.yaml. The self-hosted install appliescloud_depsfirst andcloudafterwards, so thecloud_depscopy is always overwritten and never takes effect, and nothing incloud_depsconsumes it (only the auth server and cloud proxy ink8s/clouddo). The devcloud_depsoverlay already relies solely on theory_authdefinition.The duplicate breaks users who combine the released
cloud_deps.yamlandcloud.yamlbundles in a single kustomization, as reported in the issue:This PR drops the ConfigMap from
cloud_depsand moves its explanatory comment about the supported providers to theory_authdefinition, which is the one that is actually deployed.Relevant Issues: Fixes #1840
Type of change: /kind bug
Test Plan: Built
k8s/cloud_deps/publicandk8s/cloud/publicwith kustomize v5.4.3 the same wayci/cloud_build_release.shdoes, and put both outputs in a single kustomization as in the issue. Onmainthis fails with the error above; with this change it builds successfully,cloud_deps.yamlno longer containspl-oauth-config, and the renderedpl-oauth-configfromcloud.yamlis unchanged.Changelog Message: