Repository navigation
fix: match excludedConfig against the config name, not the escaped file name - #241
Open
PaulRichez wants to merge 1 commit into
Open
PaulRichez wants to merge 1 commit into
PaulRichez wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
In
getAllConfigFromFiles, theexcludedConfigcheck now uses the config name (formattedName, with::and/), like every other place in the plugin.Why is it needed?
An exclusion on a name containing
:or/only applied to the database side, so the config stayed in the diff as "Only in sync dir". See #240.How to test it?
Add a content-manager configuration to
excludedConfigwith the name shown in the admin, e.g.core-store.plugin_content_manager_configuration_content_types::api::article.article, and runconfig-sync diff: it's no longer listed. (Checked on a Strapi 5.54 app.)Lint and integration tests pass locally (Node 22).
Note: an exclusion written with the escaped form (
##) used to hide the file only; it no longer has an effect. The name to use is the one shown in the admin.Related issue(s)/PR(s)
Fixes #240