Skip to content

fix ticket form credit entity access - #267

Merged
Herafia merged 1 commit into
11.0/bugfixesfrom
fix/ticket-form-credit-entity-access
Oct 14, 2026
Merged

Herafia merged 1 commit into
11.0/bugfixesfrom
fix/ticket-form-credit-entity-access

Conversation

@Herafia

@Herafia Herafia commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !46867
  • Here is a brief description of what this PR does

Since #242 (b2cab2c), adding a credit from a ticket's Credit tab returns the message “You do not have the required permissions,” even for Super-Admins. The access control previously checked the credit ID as if it were an entity. It now checks the credit entity, taking recursion into account. Unit tests have been added.

Screenshots (if appropriate):

@Herafia
Herafia requested a review from Lainow October 13, 2026 07:26
@Herafia Herafia self-assigned this Oct 13, 2026
@Herafia Herafia added the bug label Oct 13, 2026
@Herafia
Herafia changed the base branch from main to 11.0/bugfixes October 13, 2026 12:58
@Herafia Herafia mentioned this pull request Oct 13, 2026
4 tasks
@Herafia
Herafia merged commit 725150f into 11.0/bugfixes Oct 14, 2026
7 checks passed
@Herafia
Herafia deleted the fix/ticket-form-credit-entity-access branch October 14, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants