You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Playwright native context identity CDP type rejects Cloudflare SDK #779
Validated against current public safe-bash 0.1.691 and actual @cloudflare/playwright 1.3.6 declarations: PlaywrightContext.newCDPSession promises the full string/Record storage CDP interface, while the native SDK generic protocol sender returns concrete command interfaces without index signatures. Maintained consumer typecheck fails even after exact owned-page admission adapts the page parameter safely. A static fixture importing the real SDK reproduces two TS2322 errors.
The context identity binder only needs Target.getTargetInfo and detach. Narrow that public identity contract without changing the full private storage-lease protocol or weakening runtime target/context identity validation. Preserve generic custom host compatibility and add maintained type/runtime regressions. Dedicated home worktree worker has reproduced RED and has a focused patch; coordinator owns atomic direct-main delivery and GitHub release monitoring.
Fix verified on remote main at 7fe578f. The native context identity session now requires only Target.getTargetInfo and detach; full private lease CDP remains unchanged. Actual imported CF1.3.6 types reproduced two TS2322 diagnostics before the fix and compile cleanly afterward, as do generic custom-host compatibility and strict maintained regressions. Parent integration: 92 runtime tests pass, zero failures, one hosted skip; scoped maintained ESLint clean. Target/context identity validation remains strict. GitHub publication is monitored separately.
Activity
fix(playwright): narrow native context identity CDP contract (#779)
kamilio commentedon Sep 18, 2026
Fix verified on remote main at 7fe578f. The native context identity session now requires only Target.getTargetInfo and detach; full private lease CDP remains unchanged. Actual imported CF1.3.6 types reproduced two TS2322 diagnostics before the fix and compile cleanly afterward, as do generic custom-host compatibility and strict maintained regressions. Parent integration: 92 runtime tests pass, zero failures, one hosted skip; scoped maintained ESLint clean. Target/context identity validation remains strict. GitHub publication is monitored separately.