Repository navigation
Floxis: validate bid impression against outbound request - #4676
Open
floxis-admin wants to merge 1 commit into
Open
floxis-admin wants to merge 1 commit into
floxis-admin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Context
Floxis splits requests by seat and routing host. A response to one outbound request could return a bid for another group's impression because bid parsing used the original request's full impression list. A supplied
mtypealso bypassed impression lookup. The later response validator checks the overall auction, so it does not enforce this outbound-request boundary.Change
Validate each response bid's
impidagainsthttpCall.getRequest().getPayload().getImp()before resolving its media type. Invalid bids use the existingbad_server_responseerror and are skipped; valid bids in the same response remain accepted.Only the Floxis adapter and its unit tests change. Request grouping and configuration are unchanged.
Test plan
At
aa72a579a7f00914e72524682ce87f1b53ac3c97:./mvnw -B checkstyle:check surefire:test -Dtest=FloxisBidderTest -DargLine=-Xmx256m: 30 tests passed, zero skipped, zero Checkstyle violations. Maven heap was limited to 512MiB.mtype1 and 0. Unknown-impression cases cover both values; existing media-type cases still pass.git diff --checkpassed.The full project build/test suite was not rerun. Upstream CI must run on this PR.