Skip to content

ci: drop the duplicate Pages deploy from Build & Test - #18

Merged
ronaldtse merged 2 commits into
mainfrom
ci/drop-duplicate-deploy
Oct 23, 2026
Merged

ronaldtse merged 2 commits into
mainfrom
ci/drop-duplicate-deploy

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

The Build & Test workflow's "Deploy to GitHub Pages" job has never
succeeded: it downloads the plain dist artifact and calls
deploy-pages@v4, which requires the github-pages artifact that
only upload-pages-artifact produces ("No artifacts named
github-pages were found", red on main since at least 2026-10-22). It
also races the real deploy.yml workflow, which publishes the site
correctly on the same push.

Build & Test stays the CI gate (build + link check); deployment
belongs to deploy.yml. Main is currently red on this job:
#17's merge made it visible again.

The specs pages never survived the Astro cutover: the VitePress-era
wrappers (a Vue script-setup importing the .adoc) are not processed by
Astro, so www.pubid.com/specs/iso-urn rendered its own source snippet
and the spec content was absent from the site entirely.

- the slug route converts a spec entry's sibling .adoc with
  asciidoctor at build time (frontmatter names it; the wrapper bodies
  are gone), set:html into the article;
- the ISO URN spec is the RFC 5141-bis rewrite (the additive
  extension: harmonized stages only, the supplement year slot, the
  per-supplement stage, the deprecated abbreviation ingestion alias),
  synced byte-identical from pubid/pubid references/;
- the IEC URN spec synced from the same source of truth;
- the prebuild-generated api-reference-ruby.md is gitignored (it is
  written by fetch-api-reference.mjs at deploy time).
The deploy job downloaded the plain "dist" artifact and called
deploy-pages@v4, which requires the "github-pages" artifact from
upload-pages-artifact -- the job has never succeeded, and every push
to main ran it as a red duplicate of the real deploy.yml workflow
(the one that actually publishes the site). Build & Test is the CI
gate; deployment belongs to deploy.yml.
@ronaldtse
ronaldtse merged commit 4080c95 into main Oct 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant