Repository navigation
site: the version badge renders again; the content sweep - #19
Merged
Merged
Conversation
The VersionBadge was lost in the Astro cutover: the library and about pages imported a Vue component from the archived VitePress theme through a script-setup block Astro does not process, so the import rendered as raw text and no badge ever appeared. - fetch-api-reference.mjs also fetches the pubid gem's version from main into src/data/pubid-version.json; - src/components/VersionBadge.astro renders it at build time; the library index converts to MDX to host it; the about page links the generated API reference instead (its long raw-HTML body is not JSX-safe for MDX); - the specs index loses its empty VitePress script block; - the api-reference generated pages are gitignored (written by the prebuild at deploy time).
ronaldtse
force-pushed
the
site/fix-all-sweep
branch
from
October 24, 2026 01:24
8b0bd37 to
7bd4a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-site sweep after the specs fix — everything else broken or stale:
about pages imported a Vue component from the archived VitePress
theme through a script-setup block Astro does not process, so the
import rendered as raw text and no badge ever appeared.
fetch-api-reference.mjsnow also fetches the pubid gem's versionfrom main into
src/data/pubid-version.json;src/components/VersionBadge.astrorenders it at build time; thelibrary index converts to MDX to host it; the about page links the
generated API reference instead (its long raw-HTML body is not
JSX-safe for MDX).
docs: fix the URN spec tables asciidoctor drops cells from pubid#589 — the ISO spec's wrapped table cells now render
complete and the IEC spec converts with zero asciidoctor errors
(the unescaped
||cells were splitting into phantom cells).api-reference-*.mdpages are gitignored(written by the prebuild at deploy time).
Verified in the build:
/librarycarries thev2.0.0.pre.alpha.53badge, both spec pages render cell-complete with zero asciidoctor
errors, and no VitePress remnants remain anywhere in
src/.