Repository navigation
feat: run the skills recipes without MSBuild - #56
Merged
Merged
Conversation
The skills-* recipes now run skills.mts (Bun or Deno) or its generated skills.mjs (Node) instead of dotnet msbuild against the solution. No solution, restore or build is involved, so they take 0.4 s instead of 5 s and work when the build is broken. Settings move to the Skills section of .config/purview-build-sdk.json, overridable by recipe options and PURVIEW_SKILLS_* variables. A dry-run fix now reports and removes nothing. BREAKING CHANGE: InstallPurviewSkills, UpdatePurviewSkills, CheckPurviewSkills and FixPurviewSkills are removed, with the PurviewSkillsAgents, PurviewSkillsRunner, PurviewSkillsRunnerCandidates, PurviewSkillsPackage, PurviewSkillsCommand, PurviewSkillsSource, PurviewSkillsLockFile and PurviewSkillsDryRun properties and the PurviewSkillsAgentDirectory items. PRSKL0003 and PRSKL0009 are retired.
Updates the README, AGENTS.md, the wiki and every affected skill for the script-based skills recipes and .config/purview-build-sdk.json, with a mapping from each removed PurviewSkills* property to its new setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
skills-*recipes no longer go through MSBuild. They runskills.mts(Bun or Deno), or its generatedskills.mjs(Node), from the repository root, with no solution, restore or build involved.just skills-checktakes 0.4 s instead of 5 s on this repository's warm 8-project solution.Skillssection of.config/purview-build-sdk.json. A recipe option (for example--agents) beats aPURVIEW_SKILLS_*environment variable, which beats the file. New diagnostics:PRSKL0018(invalid file, error) andPRSKL0019(unknown key, warning).skills.mjsis generated fromskills.mtsby Node's own type stripper (just skills-script-sync). A test fails if the two drift apart.just skills-update --dry-runnow removes nothing in its fix step.Breaking changes (released as 2.2.0)
Removed: the
InstallPurviewSkills,UpdatePurviewSkills,CheckPurviewSkillsandFixPurviewSkillstargets, the solution-leader election behind them, eightPurviewSkills*properties (Agents,Runner,RunnerCandidates,Package,Command,Source,LockFile,DryRun) and thePurviewSkillsAgentDirectoryitems.PRSKL0003andPRSKL0009are retired.ValidatePurviewSkills(the pack-time check,PRSKL0005) and the properties it reads are unchanged.Migration: copy
skills.just,skills.mtsandskills.mjsfromskills/purview-buildsdk-justfile/assets/just/into.build/just/, and move any removed property into.config/purview-build-sdk.json. The skill-installation skill has a property-to-setting table.Breaking removals shipped in a minor before (1.3.0, 1.3.1), so this follows that precedent. Bump to 3.0.0 instead if preferred.
Docs
README,
AGENTS.md, the wiki (Agent Skills, Configuration Reference, Justfile, Home, Performance) and every affected skill are updated, following the docs-sync skill.Validation
just test: 1716 passed, 0 failed, 0 skipped (.NET 10 and 11). The script tests ran under Node, Bun and Deno.just lint-check,just skills-validate,just skills-script-checkandjust version-sync-checkall pass.