Repository navigation
fix: return a uint8 tuple for scalar input with bytes=True - #168
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 95.90% 95.91%
=======================================
Files 168 168
Lines 2248 2252 +4
=======================================
+ Hits 2156 2160 +4
Misses 92 92 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #153 by going with option 2 from the discussion there (thanks @matthiasschabel): scalar input with
bytes=Truenow returns a tuple of fournp.uint8, exactly like matplotlib does, rather than raising.I went with the tuple (rather than a
(4,)array) to match mpl's scalar behavior... it also meanscm(0.5, bytes=True) == (32, 144, 140, 255)just works and the result is hashable. The only thing you lose vs an array is.dtype. (I didn't reuseRGBA8here, since its alpha is a float in 0-1, while bytes mode gives alpha in 0-255.)The overloads now split on
bytes, so type checkers seeColorforbytes=Falseandtuple[np.uint8, ...]forbytes=True.🤖 Generated with Claude Code