Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abs()currently converts integer inputs to float64 despite the documented integer result. This loses precision for values such as-(2**53 + 1).The integer-preserving dispatch checks for
abs, but the wrapped NumPy function is namedabsolute. Correcting that check enables the existing integer kernels. The int64 helpers and function pointers now uselong long, matching the VM's storage on Windows as well. Minimum signed integers retain NumPy's wraparound result through an explicit guard that avoids signed-overflow undefined behavior.Extended the existing integer-function test with dtype, exact-value and minimum-integer checks. The regression fails on the original build. The rebuilt final source passes all 6042 tests with thread-count environment overrides cleared, and independent sanitizer checks pass. The default guarded environment produces three matching baseline threading-configuration failures.
Windows/MSVC and actual MKL builds were not run locally. The portability checks here were compile-only, and MKL integer helpers were tested with a type/prototype stub.
Prepared with AI assistance.