Repository navigation
Partial solve ext. cancel sideeffects. - #3072
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3070
This PR solves the below scenario, but as noted it is not possible to solve it 100% due to protocol limitations (no TID)
scenario:
If the app do not send a new request until after x ms, the response will be discarded.
if the app sends a new request less than x ms, then there are no way (no transaction id in rtu frames) to identify whether it is an old response or the correct one.
Pymodbus checks device_id (except broadcast), and function code but that does not work if the app sends same type of request.