Ignore strings inside subscripts when extracting messages - #1367
Open
Kayvan-Zahiri wants to merge 1 commit into
Open
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
pgettext(context, dictionary["key"]) treated the subscript key as the message. Strings inside brackets or braces are not arguments. Co-authored-by: Cursor <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1335.
pgettext(context, dictionary["key"])extracted"key". A dict literal in the same position was extracted too ({"msgid": "value"}becamemsgidvalue). Those strings are not arguments of the call.Strings inside
[]or{}are skipped. A nestedgettext()call is still extracted, andpgettext("navigation", "Guide")is unchanged.Tests:
PYTHONPATH=. python -m pytest --noconftest -o addopts= tests/messages/test_extract.py -q→ 12 passed. Before the fix, the new test extractedkeyandmsgidvalue.Made with Cursor