Skip to content

format_decimal: reject unsupported numbering systems with group_separator=False #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glaziermag wants to merge 1 commit into
base: master
Choose a base branch
from
Open

format_decimal: reject unsupported numbering systems with group_separator=False #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions babel/numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ def format_decimal(
:raise `UnsupportedNumberingSystemError`: If the numbering system is not supported by the locale.
"""
locale = Locale.parse(locale or LC_NUMERIC)
_get_number_symbols(locale, numbering_system=numbering_system)
if format is None:
format = locale.decimal_formats[format]
pattern = parse_pattern(format)
Expand Down
12 changes: 12 additions & 0 deletions tests/test_numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,18 @@ def test_format_decimal():
numbers.format_decimal(12345.5, locale='en_US', numbering_system="unknown")


@pytest.mark.parametrize('number', [0, 1, 1.0001])
@pytest.mark.parametrize('group_separator', [False, True])
def test_format_decimal_unsupported_numbering_system_without_fraction(number, group_separator):
with pytest.raises(numbers.UnsupportedNumberingSystemError):
numbers.format_decimal(
number,
locale='en_US',
group_separator=group_separator,
numbering_system='unknown',
)


@pytest.mark.parametrize(('input_value', 'expected_value'), [
('10000', '10,000'),
('1', '1'),
Expand Down