Repository navigation
Conversation
akx
requested changes
Oct 26, 2026
| elif lastkey: | ||
| headers[lastkey] += b'\n' + item | ||
|
|
||
| # 2026-10-10: Decode metadata using its declared charset. |
Member
There was a problem hiding this comment.
Suggested change
| # 2026-10-10: Decode metadata using its declared charset. | |
| # Decode metadata using its declared charset. |
Comment on lines
+112
to
+125
| catalog = Catalog( | ||
| charset=charset, | ||
| project='Caf\u00e9', | ||
| last_translator='Ren\u00e9 <[email protected]>', | ||
| ) | ||
| catalog.add('caf\u00e9', 'ol\u00e9', context='m\u00e9ta') | ||
| buf = BytesIO() | ||
| mofile.write_mo(buf, catalog) | ||
| buf.seek(0) | ||
| restored = mofile.read_mo(buf) | ||
| assert restored.charset == charset | ||
| assert restored.project == 'Caf\u00e9' | ||
| assert restored.last_translator == 'Ren\u00e9 <[email protected]>' | ||
| assert restored.get('caf\u00e9', context='m\u00e9ta').string == 'ol\u00e9' |
Member
There was a problem hiding this comment.
Please use the actual character instead of \u00e9 here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_mo parses the Content-Type header as bytes, but decodes the metadata message with the default UTF-8 charset before applying that header. A Latin-1 MO containing non-ASCII project or translator metadata raises UnicodeDecodeError at that point.
Apply the already parsed Content-Type through the existing MIME-header setter before decoding the metadata entry. Add roundtrips for UTF-8, Latin-1 and cp1252 catalogs with non-ASCII metadata, message IDs, contexts and translations.
Validation: the regression fails on the original source; all 6 MO tests and the complete suite (7,829 passed, 10 skipped, 2 xfailed) pass after the fix. Project Ruff and whitespace/debug hooks and sdist/wheel builds passed.
Specification: https://www.gnu.org/software/gettext/manual/html_node/MO-Files.html