Make Timezone and FixedTimezone hashable - #1021
Merged
Merged
Conversation
1 task done
ashb
reviewed
Sep 29, 2026
Pebble32
force-pushed
the
fix-timezone-hash
branch
from
September 29, 2026 12:11
8d170c3 to
3590637
Compare
Pebble32
force-pushed
the
fix-timezone-hash
branch
from
September 29, 2026 12:30
23a7eb7 to
9c72264
Compare
ashb
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimezoneandFixedTimezonedefine__eq__but not__hash__, so Python marks them unhashable and they cannot be used in sets or as dict keys:This adds
__hash__to both, hashing exactly what__eq__compares (keyforTimezone,_offsetforFixedTimezone), so equal timezones hash equal. Hashing the string form would not be correct forFixedTimezone: its repr includes the name while equality ignores it.Tests:
test_hashandtest_fixed_hashnext to the existing equality tests, including two equal fixed timezones with different names collapsing to a single set entry.Prompted by apache/airflow#73859, where Airflow currently works around this. Happy to add a changelog line if you want one.
Closed #1008, closed #1009 , closes #1019