Skip to content

docs(mailchimp): explain login-scoped identities and migration - #591

Merged
nijel merged 1 commit into
masterfrom
mailchimp
Oct 19, 2026
Merged

nijel merged 1 commit into
masterfrom
mailchimp

Conversation

@nijel

@nijel nijel commented Oct 19, 2026

Copy link
Copy Markdown
Member

Document the changed account binding, recovery for legacy associations, and the backend hook for validating nested migration evidence.

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-XHJS6Y9J.

Refs python-social-auth/social-core#2135

@nijel nijel self-assigned this Oct 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T12:34:52.324308Z 8fcb3f9 New commits
🔒 Security Review ✅ Completed 2026-10-19T12:20:06.507720Z 9cc947c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 Python Social Auth | 🛠️ Build #35241481 | 📁 Comparing 8fcb3f9 against latest (5fa863a)

  🔍 Preview build  

2 files changed
± backends/mailchimp.html
± configuration/identifier-migration.html

Document the changed account binding, recovery for legacy associations, and
the backend hook for validating nested migration evidence.

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-XHJS6Y9J.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8fcb3f9f0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +58 to +59
Before upgrading, remove any ``SOCIAL_AUTH_MAILCHIMP_ID_KEY`` or global
``SOCIAL_AUTH_ID_KEY`` value that selects ``user_id`` or another identifier.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve global ID_KEY with a Mailchimp override

For deployments that intentionally use SOCIAL_AUTH_ID_KEY for other providers, removing the global setting changes every backend's identifier selection and can break association lookup or trigger unsafe migrations; the migration guide specifically warns that a stable configured key must be retained until older associations are keyed. Since backend-specific settings take precedence, instruct these deployments to keep the global value and set SOCIAL_AUTH_MAILCHIMP_ID_KEY = "mailchimp_identity" instead.

Useful? React with 👍 / 👎.

@nijel
nijel merged commit 6c595c3 into master Oct 19, 2026
6 checks passed
@nijel
nijel deleted the mailchimp branch October 19, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant