Skip to content

docs(eveonline): explain character transfer sign-in handling - #593

Merged
nijel merged 1 commit into
masterfrom
eve
Oct 20, 2026
Merged

nijel merged 1 commit into
masterfrom
eve

Conversation

@nijel

@nijel nijel commented Oct 20, 2026

Copy link
Copy Markdown
Member

Document why transferred characters are blocked from the previous owner's association, how administrators can restore access, and the legacy backfill limit.

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-Y3LMFQ9J.

Refs python-social-auth/social-core#2137

Document why transferred characters are blocked from the previous owner's
association, how administrators can restore access, and the legacy backfill
limit.

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-Y3LMFQ9J.
@nijel nijel self-assigned this Oct 20, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T08:20:30.108505Z a562019 PR opened
🔒 Security Review ✅ Completed 2026-10-20T08:18:47.839607Z a562019 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 Python Social Auth | 🛠️ Build #35263666 | 📁 Comparing a562019 against latest (231d107)

  🔍 Preview build  

1 file changed
± backends/eveonline.html

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5620190c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +41 to +45
EVE characters can move between player accounts. This backend checks the
``CharacterOwnerHash`` returned by EVE SSO against the hash saved with an
existing ``CharacterID`` association. If the hashes differ, sign-in fails with
``identity_in_use``; the transferred character cannot access the previous
owner's local account.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not claim transfer protection before it is released

In the repository's configured documentation environment, pyproject.toml:4 pins social-auth-core[all]==6.1.1, whose EVEOnlineOAuth2 backend stores owner_hash but does not compare it during sign-in; the referenced social-core PR #2137 is not part of that release. Publishing this unqualified guarantee therefore tells operators that a transferred character cannot access the previous owner's account even though the supported release remains vulnerable. Coordinate this documentation with a core release and dependency update, or clearly state the minimum version that implements the check.

Useful? React with 👍 / 👎.

@nijel
nijel merged commit d03bb58 into master Oct 20, 2026
6 checks passed
@nijel
nijel deleted the eve branch October 20, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant