gh-152490: Fix TypeError when traceback.py formats SyntaxError(NotImplemented) by Aniketsy · Pull Request #152495 · python/cpython

Aniketsy · 2026-06-28T14:34:08Z

Method traceback.TracebackException._format_syntax_error contains line msg = self.msg or "<no detail available>".
Since 3.14, bool(NotImplemented) raises TypeError and hence so does self.msg or .... Catch it in a try statement.

Issue: "raise SyntaxError(NotImplemented)" exits REPL and IDLE subprocess #152490

…traceback.py

terryjreedy

I have no opinion on the test change.

bedevere-app · 2026-06-28T19:24:16Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

…8qLbF.rst Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>

Aniketsy · 2026-07-03T18:36:33Z

@picnixz i've updated with changes, as per your suggestion. please let me know if we need any further improvements. Thanks :)

Co-authored-by: Bénédikt Tran <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>

terryjreedy

Perhaps a formal approval will clear CI to green. I hope to merge tomorrow (Tuesday) and submit a followup about only replacing blanks with the message.

terryjreedy · 2026-10-20T04:18:47Z

@Aniketsy I have never seen these failures and don't think they should be possible for pure python PR. Did you possibly touch, view, load in editor, or otherwise somehow change last-change date or something of autoconf or generated files in your local repository? (I also asked for help elsewhere from other coredevs.)

Aniketsy · 2026-10-20T04:28:45Z

@Aniketsy I have never seen these failures and don't think they should be possible for pure python PR. Did you possibly touch, view, load in editor, or otherwise somehow change last-change date or something of autoconf or generated files in your local repository? (I also asked for help elsewhere from other coredevs.)

@terryjreedy sorry but i don't think i've touched anything, you mentioned.. and yesterday i thought it was from extra line in whatsnew entry, so i removed that but i guess i was wrong.

Aniketsy · 2026-10-20T04:49:42Z

lets see if this fixes

Aniketsy · 2026-10-20T05:26:53Z

@terryjreedy i've fixed 😊

miss-islington-app · 2026-10-21T02:18:29Z

Thanks @Aniketsy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app · 2026-10-21T02:18:39Z

GH-160009 is a backport of this pull request to the 3.15 branch.

bedevere-app · 2026-10-21T02:18:45Z

GH-160010 is a backport of this pull request to the 3.14 branch.

…(NotImplemented) (GH-152495) (#160010) gh-152490: Fix TypeError when traceback.py formats SyntaxError(NotImplemented) (GH-152495) Method traceback.TracebackException._format_syntax_error contains line `msg = self.msg or "<no detail available>"`. Since 3.14, bool(NotImplemented) raises TypeError and hence so does `self.msg or ...`. Catch it in a try statement. --------- (cherry picked from commit 5503a5e) Co-authored-by: Aniket <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>

…(NotImplemented) (GH-152495) (#160009) gh-152490: Fix TypeError when traceback.py formats SyntaxError(NotImplemented) (GH-152495) Method traceback.TracebackException._format_syntax_error contains line `msg = self.msg or "<no detail available>"`. Since 3.14, bool(NotImplemented) raises TypeError and hence so does `self.msg or ...`. Catch it in a try statement. --------- (cherry picked from commit 5503a5e) Co-authored-by: Aniket <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>

Fix TypeError when formatting SyntaxError with msg=NotImplemented in …

4663913

…traceback.py

bedevere-app Bot added the awaiting review label Jun 28, 2026

bedevere-app Bot mentioned this pull request Jun 28, 2026

"raise SyntaxError(NotImplemented)" exits REPL and IDLE subprocess #152490

Closed

blurb-it Bot and others added 2 commits June 28, 2026 14:37

📜🤖 Added by blurb_it.

03a2e53

fix format

83fc00e

picnixz reviewed Jun 28, 2026

View reviewed changes

Comment thread Lib/test/test_traceback.py Outdated

terryjreedy assigned terryjreedy and unassigned terryjreedy Jun 28, 2026

rename and update test

e6c0218

terryjreedy requested changes Jun 28, 2026

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2026-06-28-14-37-01.gh-issue-152490.A8qLbF.rst Outdated

Comment thread Lib/traceback.py Outdated

bedevere-app Bot added awaiting changes and removed awaiting review labels Jun 28, 2026

Aniketsy and others added 2 commits June 29, 2026 06:37

Update Misc/NEWS.d/next/Library/2026-06-28-14-37-01.gh-issue-152490.A…

e68c521

…8qLbF.rst Co-authored-by: Terry Jan Reedy <[email protected]>

Update Lib/traceback.py

16bfcd2

Co-authored-by: Terry Jan Reedy <[email protected]>

picnixz reviewed Jun 29, 2026

View reviewed changes

Comment thread Lib/test/test_traceback.py

Comment thread Lib/test/test_traceback.py Outdated

update tests

0c5b711

picnixz self-requested a review July 3, 2026 19:23

picnixz reviewed Sep 6, 2026

View reviewed changes

Comment thread Lib/traceback.py Outdated

picnixz reviewed Sep 6, 2026

View reviewed changes

Comment thread Lib/test/test_traceback.py Outdated

Aniketsy and others added 2 commits September 6, 2026 20:33

Update Lib/traceback.py

18295d5

Co-authored-by: Bénédikt Tran <[email protected]>

Update Lib/test/test_traceback.py

52f329d

Co-authored-by: Bénédikt Tran <[email protected]>

picnixz reviewed Sep 6, 2026

View reviewed changes

Comment thread Lib/test/test_traceback.py Outdated

Update Lib/test/test_traceback.py

e4d9b24

Co-authored-by: Bénédikt Tran <[email protected]>

terryjreedy self-assigned this Oct 19, 2026

terryjreedy added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 19, 2026

terryjreedy requested changes Oct 19, 2026

View reviewed changes

Comment thread Lib/traceback.py Outdated

Merge branch 'main' into fix-152490

36ccb0d

Aniketsy and others added 3 commits October 19, 2026 09:48

Update Lib/traceback.py

0e62eba

Co-authored-by: Terry Jan Reedy <[email protected]>

Apply review suggestion

576a8c4

Fix TypeError formatting SyntaxError with NotImplemented

ac1d1d2

terryjreedy approved these changes Oct 20, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting changes labels Oct 20, 2026

Fix line endings in NEWS entry

084abb9

terryjreedy changed the title ~~gh-152490: Fix TypeError when formatting SyntaxError with msg=NotImplemented in traceback.py~~ gh-152490: Fix TypeError when traceback.py formats SyntaxError(NotImplemented) Oct 21, 2026

terryjreedy merged commit 5503a5e into python:main Oct 21, 2026
53 checks passed

bedevere-app Bot removed the awaiting merge label Oct 21, 2026

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 21, 2026

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 21, 2026

Conversation

Aniketsy commented Jun 28, 2026 • edited by terryjreedy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Jun 28, 2026

Uh oh!

Uh oh!

Uh oh!

Aniketsy commented Jul 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

terryjreedy commented Oct 20, 2026

Uh oh!

Aniketsy commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aniketsy commented Oct 20, 2026

Uh oh!

Aniketsy commented Oct 20, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 21, 2026

Uh oh!

bedevere-app Bot commented Oct 21, 2026

Uh oh!

bedevere-app Bot commented Oct 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aniketsy commented Jun 28, 2026 •

edited by terryjreedy

Loading

Aniketsy commented Oct 20, 2026 •

edited

Loading