Repository navigation
gh-132414: Make invalid command-line options visible in the error mes… - #157921
Merged
Merged
Conversation
Member
|
Thank you for the patch. It needs to be rebased. The messages are also inconsistent: a short option is reported as |
Contributor
Author
|
Merged Both option forms now use the same format: ./python.exe -z
Invalid option '-z'
./python.exe "-q -i"
Invalid option '- '
./python.exe --foo
Invalid option '--foo'The inconsistency came from following the coreutils format proposed on the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid options were printed unquoted, so a quoted argument such as
python "-q -i", which a Linux shebang line produces, reported a bare dash followed by an invisible space.The message now follows the GNU coreutils format agreed on the issue:
pythonare erroneously quoted #132414